Minor improvements to subsection on machine representation#1316
Open
gusthoff wants to merge 17 commits intoAdaCore:mainfrom
Open
Minor improvements to subsection on machine representation#1316gusthoff wants to merge 17 commits intoAdaCore:mainfrom
gusthoff wants to merge 17 commits intoAdaCore:mainfrom
Conversation
gusthoff
force-pushed
the
content/advanced_ada/review/numerics/fixed_point_types/20260214
branch
from
6350a4c to
2b31a26
Compare
Type declaration was missing.
gusthoff
force-pushed
the
content/advanced_ada/review/numerics/fixed_point_types/20260214
branch
from
2b31a26 to
acb85da
Compare
swbaird
previously approved these changes
Mar 9, 2026
swbaird
left a comment
swbaird
left a comment
There was a problem hiding this comment.
Looks good! A couple of small comments.
swbaird
approved these changes
Mar 16, 2026
swbaird
left a comment
swbaird
left a comment
There was a problem hiding this comment.
You handled Size not via an assertion, but via a Size aspect specification to ensure that the type has the desired size.
That looks good.
Why not handle alignment the same way?
Feel free to ignore this comment - it is a very minor point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvements to subsection on machine representation of fixed-point types.